Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-74135] extract inline JS script in AbstractDependencyGraphAction/jsplumb.jelly #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[JENKINS-74135] extract inline JS script in AbstractDependencyGraphAction/jsplumb.jelly #38

wants to merge 1 commit into from

Conversation

shlomomdahan
Copy link

@shlomomdahan shlomomdahan commented Dec 5, 2024 •
edited
Loading

JENKINS-74135

This PR extracts the inline <Script> tag in AbstractDependencyGraphAction/jsplumb.jelly to comply with CSP.

Testing done

BEFORE-CHANGES:
https://github.com/user-attachments/assets/bbd30549-dda9-4b2f-acc7-a90d9ab57b81

AFTER-CHANGES:

Screen.Recording.2024-12-05.at.1.55.07.PM.mov

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shlomomdahan